Skip to content

Conversation

@farre
Copy link
Contributor

@farre farre commented Jan 13, 2026

This fixes a bug introduced by #11952, where accidentally removing an "Otherwise" results in calling "clean up" also for same-document navigations, and a subsequent refactor in #11987 that makes this harder to trace.


/nav-history-apis.html ( diff )

Copy link
Collaborator

@noamr noamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM%nits

@farre farre force-pushed the issue/12079/1 branch 2 times, most recently from beac81e to 3108946 Compare January 13, 2026 13:13
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @farre and @noamr! I fixed up the other issue @noamr spotted as well plus some drive-by nits.

@annevk annevk merged commit d927f62 into whatwg:main Jan 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants