Do not run "Update a style block" while style element is on stack of open elements #12090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…open elements When implemented as specced [1], it fails WPT test `/html/semantics/document-metadata/the-style-element/style_load_event.html` (among others). While parsing elements, it runs the "children changed steps". However, since the element is still on the stack of open elements, it also then runs when popped off. This leads to multiple invocations of the algorithm and thus multiple load events. Instead, it should mirror what's done for connected/disconnected cases where it already takes care of this scenario. [1]: servo/servo#41986
Contributor
Author
|
Given all browsers already pass these tests, I think this is considered editorial (or at least no impact?).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implemented as specced 1, it fails WPT test
/html/semantics/document-metadata/the-style-element/style_load_event.html(among others). While parsing elements, it runs the "children changed steps".
However, since the element is still on the stack of open elements, it also then
runs when popped off.
This leads to multiple invocations of the algorithm and thus multiple load events.
Instead, it should mirror what's done for connected/disconnected cases where
it already takes care of this scenario.
/html/semantics/document-metadata/the-style-element/style_load_event.html/css/cssom/HTMLStyleElement-load-event.html/css/css-fonts/font-display/font-display-failure-fallback.html(See WHATWG Working Mode: Changes for more details.)
/semantics.html ( diff )