Perform "is not origin-clean" on OffscreenCanvas too #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And list OffscreenCanvas as member in the CanvasImageSource union type description (it was already part of the IDL). Fixes #3341.
annevk
added
the
do not merge yet
|
Marking "do not merge yet" as there's still some questions surrounding OffscreenCanvas. |
junov
approved these changes
Jan 12, 2018
|
@junov so Offscreencanvas itself doesn't seem to really have this bit, only the 2d context for it. How does that work? I guess the 2d context is the bitmap so it works out? |
|
Right... In the case of HTMLCanavasElement, it is actually a shared reference. Context's output bitmap == element's bitmap. We should either define what the "OffscreenCanvas object's bitmap" refers to or change the wording to something like the "OffscreenCanvas object's context's bitmap" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And list OffscreenCanvas as member in the CanvasImageSource union type description (it was already part of the IDL).
Fixes #3341.
💥 Error: Wattsi server error 💥
PR Preview failed to build. (Last tried on Jan 15, 2021, 7:58 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.