Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to RCDATA before checking next token #5032

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jordanbtucker
Copy link

@jordanbtucker jordanbtucker commented Oct 22, 2019

See #4910 (comment)

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chrome: …
    • Firefox: …
    • Safari: …

(See WHATWG Working Mode: Changes for more details.)


💥 Error: Wattsi server error 💥

PR Preview failed to build. (Last tried on Jan 15, 2021, 8:00 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.

🔗 Related URL

Parsing MDN data...
Parsing...



If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@zcorpan
Copy link
Member

zcorpan commented Oct 22, 2019

I'm not sure @domenic counts as an implementer here, but maybe @hsivonen can chime in?

Is there a test for <textarea>\nfoo in https://github.com/html5lib/html5lib-tests ?

A quick test with http://software.hixie.ch/utilities/js/live-dom-viewer/saved/7293 shows WebKit/Blink/Gecko all following the intent of the spec, so unless a more creative test case finds bugs here, no implementation bugs need to be filed. I've not tested parse5 or other parsers though.

@domenic
Copy link
Member

domenic commented Oct 22, 2019

Right, my understanding was that this was just bringing the spec in line with existing browsers by fixing a logic bug, so we shouldn't need any new statements of implementer support.

Similarly, I'm not sure we should impose the tests requirement on a logic bug fix, but it would be good to ensure that there's coverage for this scenario if it's not too much trouble.

@gsnedders
Copy link
Member

See mine and @hsivonen's comments in #4910; I think both of us disagree that this suffices.

@domenic domenic added the do not merge yet Pull request must not be merged per rationale in comment label Oct 29, 2019
Base automatically changed from master to main January 15, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet Pull request must not be merged per rationale in comment topic: parser
Development

Successfully merging this pull request may close these issues.

5 participants