Add ::file-selector-button to the UA stylesheet #6447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
As a follow-up (or here) we should also have something like this:
::file-selector-button {
font-size: unset;
}At least that part matches all browsers:
data:text/html,<input type=file style="font-size: 5px">
In Gecko we also unset other things, not sure what Blink / WebKit do.
annevk
added
needs tests
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 5, 2021
…tentative.html. r=mstange The file button inherits the font-size of the file input, so that needs fixing. Related HTML spec PR: whatwg/html#6447 The checkbox baseline was also the other thing that was wrong, and that allows us to remove the sketchy allowedDelta. Differential Revision: https://phabricator.services.mozilla.com/D107230
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 8, 2021
…tentative.html. r=mstange The file button inherits the font-size of the file input, so that needs fixing. Related HTML spec PR: whatwg/html#6447 The checkbox baseline was also the other thing that was wrong, and that allows us to remove the sketchy allowedDelta. Differential Revision: https://phabricator.services.mozilla.com/D107230
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 10, 2021
The file button inherits the font-size of the file input, so that needs fixing. Related HTML spec PR: whatwg/html#6447 The checkbox baseline was also the other thing that was wrong, and that allows us to remove the sketchy allowedDelta. Differential Revision: https://phabricator.services.mozilla.com/D107230 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1696437 gecko-commit: c45afb640afd776a36a4ec19fe31c49269f31642 gecko-reviewers: mstange
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 10, 2021
The file button inherits the font-size of the file input, so that needs fixing. Related HTML spec PR: whatwg/html#6447 The checkbox baseline was also the other thing that was wrong, and that allows us to remove the sketchy allowedDelta. Differential Revision: https://phabricator.services.mozilla.com/D107230 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1696437 gecko-commit: c45afb640afd776a36a4ec19fe31c49269f31642 gecko-reviewers: mstange
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 10, 2021
…tentative.html. r=mstange The file button inherits the font-size of the file input, so that needs fixing. Related HTML spec PR: whatwg/html#6447 The checkbox baseline was also the other thing that was wrong, and that allows us to remove the sketchy allowedDelta. Differential Revision: https://phabricator.services.mozilla.com/D107230 UltraBlame original commit: c45afb640afd776a36a4ec19fe31c49269f31642
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 10, 2021
…tentative.html. r=mstange The file button inherits the font-size of the file input, so that needs fixing. Related HTML spec PR: whatwg/html#6447 The checkbox baseline was also the other thing that was wrong, and that allows us to remove the sketchy allowedDelta. Differential Revision: https://phabricator.services.mozilla.com/D107230 UltraBlame original commit: c45afb640afd776a36a4ec19fe31c49269f31642
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 10, 2021
…tentative.html. r=mstange The file button inherits the font-size of the file input, so that needs fixing. Related HTML spec PR: whatwg/html#6447 The checkbox baseline was also the other thing that was wrong, and that allows us to remove the sketchy allowedDelta. Differential Revision: https://phabricator.services.mozilla.com/D107230 UltraBlame original commit: c45afb640afd776a36a4ec19fe31c49269f31642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per w3c/csswg-drafts#5788 (comment)
This wasn't covered in #6250 by @emilio but is implemented in Gecko: https://phabricator.services.mozilla.com/D88995#change-Qm2jIAAP02Sm
(See WHATWG Working Mode: Changes for more details.)
/rendering.html ( diff )