-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Take sizes from <img> if a <source> doesn't have a sizes attribute #6695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5a1d1d3 to
d99f295
Compare
|
I'll create the implementation bugs if folks are happy with this. |
|
Open question, should the return of |
I think no. It's less surprising if it more closely reflects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The document conformance requirements should be changed to allow specifying sizes on img (maybe unconditionally for simplicity). And require sizes on img if one of the sources uses w and omits sizes.
|
TODO: Simplify |
Fixes #6633 by allowing sizes data to come from the
<img>if a particular sibling<source>doesn't have asizesattribute.(See WHATWG Working Mode: Changes for more details.)
/images.html ( diff )
/infrastructure.html ( diff )
/embedded-content.html ( diff )
/images.html ( diff )