Fix a step in 'update the image data' #8182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the 'update the image data' algorithm when src is set to the same value. Fixes #8080.
domenic
approved these changes
Aug 12, 2022
There was a problem hiding this comment.
LGTM. I would prefer the commit message use a word like "Fix" instead of "Clarify", and mention in particular the problem ("this only restarts the animation / returns if current request's state is partially available, not if it's completely available. That seems wrong") since I thought at first this was editorial.
Tests would be nice if you could, but I can understand that this is probably just an oversight and not worth testing. Maybe worth digging around to see if it's already tested, I guess.
zcorpan
changed the title
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 15, 2022
zcorpan
added
do not merge yet
|
See #8080 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the 'update the image data' algorithm when src is set to the same value. Previously, it would only restart the animation / return if current request's state is partially available, not if it's completely available.
Fixes #8080.
/images.html ( diff )