feat: refactor common file API #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daohu527
force-pushed
the
38-bug-logic-error-in-deletefile
branch
3 times, most recently
from
c7c4f0d to
6e5a402
Compare
daohu527
force-pushed
the
38-bug-logic-error-in-deletefile
branch
from
6e5a402 to
ff76da4
Compare
lykling
reviewed
Oct 25, 2025
Member
lykling
left a comment
lykling
left a comment
There was a problem hiding this comment.
glob方法实现的效果和传统定义的不一致，建议再看下
其它的问题不大，建议对删除的接口增加一个给用户的迁移的引导
| case ')': | ||
| case '{': | ||
| case '}': | ||
| case '[': |
| case '}': | ||
| case '[': | ||
| case ']': | ||
| case '\\': |
Member
There was a problem hiding this comment.
特殊case，如果匹配模式是是*.xxx 会被转成 \.*.xxx，匹配不到正确的结果
daohu527
added a commit
that referenced
this pull request
Oct 25, 2025
* feat: refactor common file API * chore: add note about Glob chore: fix commit error in file.h (#40) * feat: refactor common file API chore: fix commit error in file.h * chore: fix commit error in file.h
WildBeast114514
pushed a commit
to WildBeast114514/apollo-lite
that referenced
this pull request
Oct 28, 2025
This reverts commit 40c9f7d.
daohu527
pushed a commit
that referenced
this pull request
Oct 31, 2025
* feat(tools): migration of cyber visualizer on jetson * Clean up Qt5 installation and add dependencies Remove old Qt5 installation and update dependencies. * Revert "feat: refactor common file API (#39)" This reverts commit 40c9f7d. --------- Co-authored-by: WildBeast114514 <[email protected]>
daohu527
pushed a commit
that referenced
this pull request
Nov 6, 2025
* feat(tools): migration of cyber visualizer on jetson * Clean up Qt5 installation and add dependencies Remove old Qt5 installation and update dependencies. * Revert "feat: refactor common file API (#39)" This reverts commit 40c9f7d. * fix(tools): display issue of camera --------- Co-authored-by: WildBeast114514 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor common file API use modern c++17 API
motivation: ApolloAuto/apollo#15740