-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add options panel #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…fer of threads Signed-off-by: AnsahMohammad <[email protected]>
Signed-off-by: AnsahMohammad <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first PR! And sorry that it took a bit longer for me to check it.
Before I dig into all the changes I wanted to have a look how it actually works, but at least one of the changes is actually breaking the extension. Can you please check yourself? From the command line you can run npm run start:firefox -- --firefox=nightly
to actually start a Nightly build with the webextension running. For me no values are displayed and certain actions like switching between pages, threads etc fails as well.
// TODO: Set enabled status based on global setting and selected sidebar | ||
// process pane. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets keep those comments that are not addressed with your PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! It looks like the recent commit caused an "Assignment to constant variable" error. This also highlights the need to start adding tests to catch such issues early. Thanks for checking it! |
Add options pane in the top-left with following options :
This PR resolves #50