Skip to content

feat: add options panel #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

AnsahMohammad
Copy link
Contributor

Add options pane in the top-left with following options :

  • update-interval-slider
  • set transfer-pages
  • set transfer-threads

This PR resolves #50

@AnsahMohammad
Copy link
Contributor Author

Screenshot of the implementation :

image

@AnsahMohammad AnsahMohammad changed the title feat: add options pane feat: add options panel Mar 1, 2025
Copy link
Owner

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first PR! And sorry that it took a bit longer for me to check it.

Before I dig into all the changes I wanted to have a look how it actually works, but at least one of the changes is actually breaking the extension. Can you please check yourself? From the command line you can run npm run start:firefox -- --firefox=nightly to actually start a Nightly build with the webextension running. For me no values are displayed and certain actions like switching between pages, threads etc fails as well.

Comment on lines -13 to -14
// TODO: Set enabled status based on global setting and selected sidebar
// process pane.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep those comments that are not addressed with your PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed these comments referred to the boolean buttons we added here:
image

Since we're handling this logic in option.js, I thought they were no longer needed.

@AnsahMohammad
Copy link
Contributor Author

Thank you for your first PR! And sorry that it took a bit longer for me to check it.

Before I dig into all the changes I wanted to have a look how it actually works, but at least one of the changes is actually breaking the extension. Can you please check yourself? From the command line you can run npm run start:firefox -- --firefox=nightly to actually start a Nightly build with the webextension running. For me no values are displayed and certain actions like switching between pages, threads etc fails as well.

Oops! It looks like the recent commit caused an "Assignment to constant variable" error. This also highlights the need to start adding tests to catch such issues early. Thanks for checking it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add options panel
2 participants