Skip to content

Migrate PushService methods to the emulated HTTP request/response inside of the websocket #1179

Migrate PushService methods to the emulated HTTP request/response inside of the websocket

Migrate PushService methods to the emulated HTTP request/response inside of the websocket #1179

Triggered via pull request November 18, 2025 13:29
Status Failure
Total duration 1m 26s
Artifacts

ci.yaml

on: pull_request
Check code formatting
7s
Check code formatting
Clippy
1m 22s
Clippy
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

15 errors
use of `default` to create a unit struct: src/websocket/mod.rs#L384
error: use of `default` to create a unit struct --> src/websocket/mod.rs:384:24 | 384 | _type: PhantomData::default(), | ^^^^^^^^^^^----------- | | | help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#default_constructed_unit_structs = note: `-D clippy::default-constructed-unit-structs` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::default_constructed_unit_structs)]`
the `Err`-variant returned from this function is very large: src/websocket/request.rs#L71
error: the `Err`-variant returned from this function is very large --> src/websocket/request.rs:71:10 | 71 | ) -> Result<WebSocketRequestBuilder<'_, C>, ServiceError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ::: src/push_service/error.rs:51:5 | 51 | WsError(#[from] reqwest_websocket::Error), | ----------------------------------------- the largest variant contains at least 136 bytes | = help: try reducing the size of `push_service::error::ServiceError`, for example by boxing large elements or replacing it with `Box<push_service::error::ServiceError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#result_large_err
useless conversion to the same type: `push_service::error::ServiceError`: src/websocket/registration.rs#L311
error: useless conversion to the same type: `push_service::error::ServiceError` --> src/websocket/registration.rs:311:15 | 311 | .await | _______________^ | |_______________| 312 | || .map_err(Into::into) | ||____________________________^ 313 | | } | |_____- help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `push_service::error::ServiceError`: src/websocket/registration.rs#L286
error: useless conversion to the same type: `push_service::error::ServiceError` --> src/websocket/registration.rs:286:19 | 286 | .await | ___________________^ | |___________________| 287 | || .map_err(Into::into) | ||________________________________^ 288 | | } | |_____- help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `push_service::error::ServiceError`: src/websocket/registration.rs#L234
error: useless conversion to the same type: `push_service::error::ServiceError` --> src/websocket/registration.rs:234:15 | 234 | .await | _______________^ | |_______________| 235 | || .map_err(Into::into) | ||____________________________^ 236 | | } | |_____- help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `push_service::error::ServiceError`: src/websocket/registration.rs#L195
error: useless conversion to the same type: `push_service::error::ServiceError` --> src/websocket/registration.rs:195:15 | 195 | .await | _______________^ | |_______________| 196 | || .map_err(Into::into) | ||____________________________^ 197 | | } | |_____- help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `push_service::error::ServiceError`: src/websocket/registration.rs#L155
error: useless conversion to the same type: `push_service::error::ServiceError` --> src/websocket/registration.rs:155:19 | 155 | .await | ___________________^ | |___________________| 156 | || .map_err(Into::into) | ||________________________________^ 157 | | } | |_____- help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `push_service::error::ServiceError`: src/websocket/profile.rs#L76
error: useless conversion to the same type: `push_service::error::ServiceError` --> src/websocket/profile.rs:76:19 | 76 | .await | ___________________^ | |___________________| 77 | || .map_err(Into::into) | ||________________________________^ 78 | | } | |_____- help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `push_service::error::ServiceError`: src/websocket/keys.rs#L290
error: useless conversion to the same type: `push_service::error::ServiceError` --> src/websocket/keys.rs:290:15 | 290 | .await | _______________^ | |_______________| 291 | || .map_err(Into::into) | ||____________________________^ 292 | | } | |_____- help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `push_service::error::ServiceError`: src/websocket/keys.rs#L185
error: useless conversion to the same type: `push_service::error::ServiceError` --> src/websocket/keys.rs:185:37 | 185 | device.into_bundle(identity).map_err(Into::into) | _____________________________________-^^^^^^^^^^^^^^^^^^^ 186 | | } | |____- help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `push_service::error::ServiceError`: src/websocket/keys.rs#L99
error: useless conversion to the same type: `push_service::error::ServiceError` --> src/websocket/keys.rs:99:15 | 99 | .await | _______________^ | |_______________| 100 | || .map_err(Into::into) | ||____________________________^ 101 | | } | |_____- help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
the `Err`-variant returned from this function is very large: src/websocket/keys.rs#L51
error: the `Err`-variant returned from this function is very large --> src/websocket/keys.rs:51:10 | 51 | ) -> Result<PreKeyBundle, ServiceError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ::: src/push_service/error.rs:51:5 | 51 | WsError(#[from] reqwest_websocket::Error), | ----------------------------------------- the largest variant contains at least 136 bytes | = help: try reducing the size of `push_service::error::ServiceError`, for example by boxing large elements or replacing it with `Box<push_service::error::ServiceError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#result_large_err = note: `-D clippy::result-large-err` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::result_large_err)]`
useless conversion to the same type: `push_service::error::ServiceError`: src/websocket/account.rs#L132
error: useless conversion to the same type: `push_service::error::ServiceError` --> src/websocket/account.rs:132:19 | 132 | .await | ___________________^ | |___________________| 133 | || .map_err(Into::into) | ||________________________________^ 134 | | } | |_____- help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `push_service::error::ServiceError`: src/websocket/account.rs#L92
error: useless conversion to the same type: `push_service::error::ServiceError` --> src/websocket/account.rs:92:19 | 92 | .await | ___________________^ | |___________________| 93 | || .map_err(Into::into) | ||________________________________^ 94 | | } | |_____- help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
Clippy
Clippy had exited with the 101 exit code