-
Notifications
You must be signed in to change notification settings - Fork 36
Migrate PushService methods to the emulated HTTP request/response inside of the websocket #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@gferon yes please, this looks very good to me! |
|
Looks like a good direction to go forward with! |
Lemme try to go crazy tonight or tomorrow and move forward. |
|
@rubdos I'm pretty happy with this, you can look for reference at the other side of the story in |
|
Note that this bumps MSRV to 1.88 (can't remember by whom exactly) but edition is still 2021. @gferon Can you estimate how complete this PR is? This will be required soon... |
|
I think it's actually finished as far as I could test. See the relevant changes in presage, @Schmiddiii even tested on Flare IIRC. |
I indeed did. Linking, groups, and stickers worked as expected (at least as of 2025-11-19, not sure if anything changed since then), I did not try registering though as Flare does not yet support that officially. I also did not look at the code yet, but I likely don't know too much about the internals of Signal to be of much use for a review of the code. |
|
I tested linking as secondary, and in principle it worked. I'm having a little trouble creating the websockets in the right places at the right time, so I can't do much after linking. Didn't test registration as primary yet though. |
|
@direc85 both linking and registration didn't change 😂 but all the other operations once you register, like registering pre-keys and send/receive operations. I think we should merge this, rip the band-aid, go in the corner, sit down, cry a lot and get back on our toes afterwards. |
direc85
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure how and where clients (Whisperfish) should be creating websockets, but as I'm able to daily drive it, I'll approve this PR. We have to get this forward.
f65fb72 to
c2bd0e7
Compare
No description provided.