fix: skip sync transcript for non-syncable message types#391
Open
lightclient wants to merge 1 commit intowhisperfish:mainfrom
Open
fix: skip sync transcript for non-syncable message types#391lightclient wants to merge 1 commit intowhisperfish:mainfrom
lightclient wants to merge 1 commit intowhisperfish:mainfrom
Conversation
Typing indicators, receipts, and other ephemeral messages cannot produce valid sync transcripts. Previously, send_message and send_message_to_group would unconditionally enter the sync block when is_multi_device was true, causing create_multi_device_sent_transcript_content to return None and log an error for every non-DataMessage/EditMessage send. Guard all three sync blocks with an is_syncable check so that ephemeral message types skip the sync path entirely.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was getting a lot of errors when trying to send a
TypingMessage.Seems like more ephemeral messages like the typing indicator shouldn't create sync transcripts. Not sure if more types should be in
is_syncable, but what I can tell fromcreate_multi_device_sent_transcript_contentthose are the only 3ContentBodys that create a sync transcript and should be considered "syncable".