Fix primary device mode #352
Conversation
|
This PR now pretty much depends on #343 as presage is not yet up-to-date with the libsignal-service-rs main branch, and as this PR now depends upon whisperfish/libsignal-service-rs#383 , which still needs to be updated to support the main branch in order to be merged. |
Schmiddiii
force-pushed
the
primary-device
branch
2 times, most recently
from
5fbfe37 to
4e0b16c
Compare
Schmiddiii
force-pushed
the
primary-device
branch
from
4e0b16c to
3fbaea8
Compare
|
Temporarily depending on a |
|
Note: The migration present here is actually slightly wrong, and can fail in the case that there are different records with the same address and record but different device ID. See this downstream bug. Sadly, I already shipped the migration to Flare users (I had a beta release with this primary device mode, but then came the hotfix release a few days ago). So I'm not sure if we can fix the migration properly. Or do you have any ideas? |
There is always a way to add another migration, to iterate over all migrations in Rust and skip the wrong migration. If it was already applied, then ok. But next migration must be compatible with it though. If it was not applied, then the next migration can be just applied. |
|
Fixed the broken migration by reverting it in the code and replacing it with a working migration. |
Schmiddiii
force-pushed
the
primary-device
branch
from
cb73f1c to
211c9d5
Compare
2 participants
This attempts to fix all things required to allow using presage as a primary device.
This fixes #328.
TODO:
Migration for deleting thedevice_idcolumn foridentites.Answer some more sync requests (does not seem to be strictly needed, but are implemented in Whisperfish):KeysBlockedContacts (real implementation, no dummy).Figure out why listing devices does not work.