Fix: Correct column calculation for zoomed-in displays #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you so much! This bug was causing a visually unpleasant experience 😅 There is some code you have that's from another PR -- #896 -- but I'll make sure to merge that one in first to make the file changes reflect the PR-specific changes 👍 (no need for you to do anything about this) I really appreciate all the additions you're making to Video Hub App ❤️ 😊 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue I have addressed: #840
What I Did:
Restored the saved zoom level using webFrame.setZoomFactor(currentZoomLevel)
After applying zoom, forced a gallery layout refresh using computePreviewWidth() and virtualScroller.refresh() inside a setTimeout(..., 0)
This ensures the correct number of columns is rendered even when a zoom level like 150% is used
The change eliminates the issue of one column being missing on cold start due to delayed zoom application
Verified proper layout at both 100% and 150% zoom levels
Confirmed that dynamic resizing continues to work smoothly at all zoom levels
Big cheers and thanks for reviewing this! Hope it keeps the gallery looking sharp across zoom levels.