fix: replace bare except: with except ImportError: in optional import guards#1602
Open
harshadkhetpal wants to merge 2 commits into
Conversation
Contributor
|
This PR is stale. Remove stale label or it will be closed next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace bare
except:clauses with specificexcept ImportError:in optional import guard blocks.Changes
python/whylogs/core/preprocessing.py: Thetry/exceptblock guards an optionalimport pandas.core.dtypes.common— catching onlyImportErroris more precise and avoids silently swallowing unexpected errors.python/whylogs/core/datatypes.py: Thetry/exceptblock guards an optionalfrom pandas.core.api import CategoricalDtype— same fix.Why
Bare
except:catches all exceptions includingSystemExit,KeyboardInterrupt, and programming errors likeSyntaxError. For optional dependency imports,except ImportError:is the correct and intended exception to catch. This aligns with Python best practices (PEP 8) and makes error handling more explicit.Testing
These are import-time guard blocks with no behavioral change when pandas is/isn't installed. The only difference is that non-import errors are no longer silently swallowed.