Skip to content

Fix HITOKOTO parameter boolean/string type handling #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Fix HITOKOTO parameter boolean/string type handling #2918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1bc9b2
Initial plan
Copilot Jan 29, 2026
d1a6570
Fix HITOKOTO parameter type mismatch in notify scripts
Copilot Jan 29, 2026
13c35b7
Refactor JavaScript HITOKOTO check for consistency with Python
Copilot Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sample/notify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1511,7 +1511,7 @@ async function sendNotify(text, desp, params = {}) {
}
}

if (push_config.HITOKOTO !== 'false') {
if (![false, 'false'].includes(push_config.HITOKOTO)) {
desp += '\n\n' + (await one());
}

Expand Down
2 changes: 1 addition & 1 deletion sample/notify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,7 +1088,7 @@ def send(title: str, content: str, ignore_default_config: bool = False, **kwargs
return

hitokoto = push_config.get("HITOKOTO")
content += "\n\n" + one() if hitokoto != "false" else ""
content += "\n\n" + one() if hitokoto not in [False, "false"] else ""

notify_function = add_notify_function()
ts = [
Expand Down
2 changes: 1 addition & 1 deletion sample/notify.py.save
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,7 +991,7 @@ def send(title: str, content: str, ignore_default_config: bool = False, **kwargs
return

hitokoto = push_config.get("HITOKOTO")
content += "\n\n" + one() if hitokoto != "false" else ""
content += "\n\n" + one() if hitokoto not in [False, "false"] else ""

notify_function = add_notify_function()
ts = [
Expand Down