This repository was archived by the owner on Jul 1, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
Issue #373: ANIm should not be symmetric #376
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
What is the reason for retaining and skipping them? I would have thought deleting/removing the tests would be appropriate. |
Contributor
Author
I wanted to think a bit about whether there might be a different use for it (there's really only one such test), or whether it might be usefully repurposed before completely removing it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 75.98% 75.77% -0.21%
==========================================
Files 55 55
Lines 3747 3740 -7
==========================================
- Hits 2847 2834 -13
- Misses 900 906 +6 🚀 New features to boost your workflow:
|
This code assumed symmetry from anim
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, ANIm is no longer treated as symmetric. Comparisons between each pair of genomes are run in both directions; enforced sorting of output file names has been disabled; tests relying on this sorting are skipped; and documentation has been updated.
Closes #373.
Type of change
Action Checklist
pyanirepository under your own account (please allow write access for repository maintainers)CONTRIBUTING.md)pytest -vnon-passing code will not be mergedorigin/masterflake8andblackbefore submissionPull requestssection in thepyanirepository