Tidy up code and javadoc #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noordfrees
added
documentation
matthiakl
reviewed
Sep 3, 2021
wl/server/Command.java
Outdated
Comment on lines
64
to
68
| * If the password is correct, the server replies not <code>ADMIN</code>/<code>SUCCESS</code> but | ||
| * instead prints out server statistics in the following format: <ul> <li> Time in [1: milliseconds | ||
| * | 2+: hours] since the server was started, <code>\n</code> <li> {@literal Protocol version >= 2}: | ||
| * Average client lifetime in seconds, <code>\n</code> <li> Protocol version 1: <ul><li> Number of | ||
| * current registered users, <code>\n</code> <li> Number of current unregistered users, |
There was a problem hiding this comment.
Hm, stupid clang-format...
Is there a way to disable formatting of doc comments?
There was a problem hiding this comment.
Ouch!
There seems to be no standard way to skip javadoc comments so I disabled clang-format for the whole file. The rest of the documentation should be fine I hope…
matthiakl
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #97