fix: support numpy2 compatibility #448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since numpy2 we need to explicitly decide how to deal with values out of range.
|
I think that's a reasonable fix. Is this compatible with numpy 1? If not, can we make it compatible? |
|
Both functions exists in 1.26, so I'd say yes. It's a bit hard to test for me in this environment, as numpy2 propagates from all other inputs as well and would need to be replaced. |
|
I tried to do the overrides in downstream dependencies (bqplot, bqscales, pandas), but it's not possible to build pandas with numpy 1 anymore, making it really hard for me to test here. Are you able to run the tests from your side, with a numpy 1 in the environment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since numpy2 we need to explicitly decide how to deal with values out of range.