fix(fonts): update text-shaper to 0.1.28 - #33
Merged
Conversation
Deploying restty with
|
| Latest commit: |
ab6a04f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8cf2bb39.restty.pages.dev |
| Branch Preview URL: | https://agent-update-text-shaper-0-1.restty.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Apple Color Emoji implements complex emoji sequences as AAT
morxligatures. Text-shaper's class lookup, ligature-table parsing, and state-machine action processing were incomplete, so the sequences remained separate component glyphs and could not enter restty's single-glyph color atlas path.Text-shaper 0.1.28 implements the missing lookup and ligature data, follows Apple/HarfBuzz action semantics, treats zero substitutions as no-ops, bounds binary-table regions, rejects invalid component indices, and avoids duplicate component pushes across
DontAdvancetransitions.Validation
text-shaper@0.1.28bun install --frozen-lockfilebun run check:themesbun run format:checkbun run lintbun run build:typesbun run buildbun run playground:buildUpstream: wiedymi/text-shaper#6
Follow-up to #30