morebits: remove message i18n #2289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has never really been used anywhere in the intended way. For example, on [Bangla Wikipedia](https://bn.wikipedia.org/wiki/MediaWiki:Gadget-morebits.js), they have modified the defaults inline, which defeats the point. The intended usage was to define messages in a JSON object, load them into an i18n lib like jquery.i18n and attach it to morebits via Morebits.i18n.setParser(). The [Chinese Wikipedia](https://zh.wikipedia.org/wiki/MediaWiki:Gadget-morebits.js) skips Morebits.i18n altogether in favour of defining messages inline. The only usage is in Twinkle-core which anyway has its own copy of morebits. At this point, continuing to maintain this system feels like technical debt that also impedes readability of code where messages are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has never really been used anywhere in the intended way. For example, on Bangla Wikipedia, they have modified the defaults inline, which defeats the point. The intended usage was to define messages in a JSON object, load them into an i18n lib like jquery.i18n and attach it to morebits via Morebits.i18n.setParser(). The Chinese Wikipedia skips Morebits.i18n altogether in favour of defining messages inline.
The only usage is in Twinkle-core which anyway has its own copy of morebits. At this point, continuing to maintain this system feels like technical debt that also impedes readability of code where messages are used.