morebits: fix integration with Navigation Popups#2308
Merged
siddharthvp merged 1 commit intomasterfrom Feb 8, 2026
Merged
Conversation
siddharthvp
force-pushed
the
simplewindow-popups
branch
from
784eada to
53fa273
Compare
- Remove obsolete code to integrate with navpopups via window.setupTooltips which is no longer exposed. - Fire the wikipage.content hook instead, which is handled by navpopups. This is only done for content of previews, as popups for other links in Twinkle dialogs are unnecessary. - Change base z-index of dialog to 500. As popups uses 1000, this ensures that popups always appear over the dialog. Fixes #2307
siddharthvp
force-pushed
the
simplewindow-popups
branch
from
53fa273 to
75e472b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2307