morebits: port SimpleWindow from jQuery UI to plain JS #2309
Merged
siddharthvp merged 1 commit intomasterfrom Feb 14, 2026
Merged
morebits: port SimpleWindow from jQuery UI to plain JS #2309siddharthvp merged 1 commit intomasterfrom
siddharthvp merged 1 commit intomasterfrom
Conversation
Member
Author
|
QA checklist:
|
d0adc9a to
2c31a36
Compare
3476324 to
76b55c0
Compare
siddharthvp
commented
Feb 8, 2026
a65f710 to
3b757e1
Compare
66e887a to
877f8c1
Compare
Looks and behaves exactly like the existing UI. There is also not much difference in the number of lines of code. It turns out that using jquery.ui and applying our tweaks over it wasn't really making the code lesser than re-implementing the dialog from scratch. It took more than a week to get all the rough edges straightened out. I think the result is cleaner and more maintainable than the previous version. In particular, the CSS no longer needs to use `!important` or use over-specific selectors or `inherit` values to override jquery.ui behaviour. The only visible changes are: * Resizing is only supported from the bottom-right corner (similar to CSS native resize). Earlier, it was supported from all four corners and four edges. We could do that if there's demand. * The close button looks a bit different (but behaves similarly). Any other differences from the previous UI should be reported as a bug. Partially solves #2300.
877f8c1 to
974c78f
Compare
Member
Author
|
I've checked for all kinds of UI issues I can think of over the past two weeks. Let's see how this goes :/ |
siddharthvp
added a commit
that referenced
this pull request
Feb 15, 2026
After jQuery UI migration (#2309), we need to use .morebits-dialog-title instead of `.ui-dialog-title`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks and behaves exactly like the existing UI. There is also not much difference in the number of lines of code. It turns out that using jquery.ui and applying our tweaks over it wasn't really making the code lesser than re-implementing the dialog from scratch.
It took more than a week to get all the rough edges straightened out. I think the result is cleaner and more maintainable than the previous version. In particular, the CSS no longer needs to use
!importantor use over-specific selectors orinheritvalues to override jquery.ui behaviour.The only visible changes are:
Any other differences from the previous UI should be reported as a bug.
Partially solves #2300.