block: turn templating on by default only for registered accounts#2313
Open
IlyasLebleu wants to merge 1 commit intowikimedia-gadgets:masterfrom
Open
block: turn templating on by default only for registered accounts#2313IlyasLebleu wants to merge 1 commit intowikimedia-gadgets:masterfrom
IlyasLebleu wants to merge 1 commit intowikimedia-gadgets:masterfrom
Conversation
siddharthvp
reviewed
Feb 11, 2026
| tooltip: 'If the blocking admin forgot to issue a block template, or you have just blocked the user without templating them, you can use this to issue the appropriate template. Check the partial block box for partial block templates.', | ||
| // Disallow when viewing the block dialog on an IP range | ||
| checked: !Morebits.ip.isRange(relevantUserName), | ||
| checked: false, |
Member
There was a problem hiding this comment.
Can't this be written as !mw.util.isIPAddress(relevantUserName, true) ? That will make it checked for registered accounts and temp accounts, and unchecked for IPs and IP ranges. No need to wait for fetch of user info.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually, IPs don't need a block template since it won't be visible, although the option is left available in case an administrator might want to leave a notice there for future use. Works as expected on test.wikipedia.org