Skip to content
This repository was archived by the owner on May 28, 2026. It is now read-only.

T383002 | Format language arrays in models.json to multi-line style#157

Merged
samwilson merged 2 commits into
wikimedia:mainfrom
vm-pranavan:GCVE
Mar 2, 2026
Merged

T383002 | Format language arrays in models.json to multi-line style#157
samwilson merged 2 commits into
wikimedia:mainfrom
vm-pranavan:GCVE

Conversation

@vm-pranavan

Copy link
Copy Markdown
Contributor

No description provided.

@samwilson

Copy link
Copy Markdown
Member

Thanks for this! I assume this is format is wanted in order to make it easier to update the models.json file programmatically. If so, it'd be good to explain that in the PR description (see also the commit message guidelines, including how to reference the task number).

Also, there are some unrelated changes that should be done in a separate PR.

@vm-pranavan vm-pranavan force-pushed the GCVE branch 2 times, most recently from 13a2d9d to d4e746f Compare March 1, 2026 14:40
Use documentTextDetection instead of textDetection for better
recognition of complex diacritic characters used in mnp.

Bug: T383002
@vm-pranavan

Copy link
Copy Markdown
Contributor Author

Hi @samwilson

Thanks for the review!

The unrelated formatting changes have been removed — the PR now only contains the two intentional changes:

  1. Adding mnp (Northern Min) to models.json
  2. Switching textDetection → documentTextDetection for better diacritic recognition

The commit message has also been updated to reference the task: Bug: T383002

@samwilson

Copy link
Copy Markdown
Member

Will be back at my desk tomorrow so will review then. I seem to remember switching to document-text-detection was talked about (and done!) before: https://phabricator.wikimedia.org/T246944#5978037 (not sure why we switched back to text-detection).

@vm-pranavan

Copy link
Copy Markdown
Contributor Author

Hi @samwilson

Thanks for the context! It looks like documentTextDetection was reverted unintentionally at some point — this PR restores the original intended behaviour.

@samwilson samwilson merged commit 105fce5 into wikimedia:main Mar 2, 2026
3 checks passed
@samwilson

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants