T383002 | Format language arrays in models.json to multi-line style#157
Conversation
|
Thanks for this! I assume this is format is wanted in order to make it easier to update the models.json file programmatically. If so, it'd be good to explain that in the PR description (see also the commit message guidelines, including how to reference the task number). Also, there are some unrelated changes that should be done in a separate PR. |
13a2d9d to
d4e746f
Compare
Use documentTextDetection instead of textDetection for better recognition of complex diacritic characters used in mnp. Bug: T383002
|
Hi @samwilson Thanks for the review! The unrelated formatting changes have been removed — the PR now only contains the two intentional changes:
The commit message has also been updated to reference the task: Bug: T383002 |
|
Will be back at my desk tomorrow so will review then. I seem to remember switching to document-text-detection was talked about (and done!) before: https://phabricator.wikimedia.org/T246944#5978037 (not sure why we switched back to text-detection). |
|
Hi @samwilson Thanks for the context! It looks like documentTextDetection was reverted unintentionally at some point — this PR restores the original intended behaviour. |
|
Thanks! |
No description provided.