-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make error implement std::io::Error and remove associated Agent's Error type #15
Conversation
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
I'm wondering what do you think about it @baloo? I'm on the edge to completely remove |
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
I might want to revisit error in #16. I don't know yet. Can we hold off on this? |
As far as I know we don't have any deadlines here 😏 😉 |
BTW thanks for all your contributions. This crate was in dire need of maintenance but I just never had time to do it properly. Thanks! 🙏 |
Split Agent and Session for per-session use-cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can use the content of #17 and we can always revisit this PR later
Okay, thanks! I was just looking at how to merge #17 back without this but didn't get anywhere :) |
I've also checked #16 and I think it won't be that hard to rebase... the only thing is adding Display match arms to new errors but it should be mostly straightforward. |
No description provided.