Add integration tests #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-k
force-pushed
the
add-e2e-tests
branch
17 times, most recently
from
8a94705 to
b4f6d9b
Compare
This PR addresses the problem of checking if the agent is properly functioning for it's most basic task: signing requests. Instead of spawning a new sshd daemon this PR takes a different approach: using SSH file signatures which execute the same piece of code. On Windows a slight change is required: a file is created to signal to the script that it's ready to serve requests. Sadly it doesn't seem that checking `IF EXISTS "\\.\pipe\agent"` works. Fixes: #12 Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
|
I'm going to merge this as it's going to be critically important in #26. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the problem of checking if the agent is properly functioning for it's most basic task: signing requests.
Instead of spawning a new sshd daemon this PR takes a different approach: using SSH file signatures which execute the same piece of code.
On Windows a slight change is required: a file is created to signal to the script that it's ready to serve requests. Sadly it doesn't seem that checking
IF EXISTS "\\.\pipe\agent"works :/