Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialization failure #5

Merged
merged 4 commits into from
Sep 10, 2016
Merged

Fix initialization failure #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d665ed0
Fix table creation order in initialize! #1
temochka Aug 23, 2016
551256f
Use core/initialize! to prepare db in tests.
temochka Aug 23, 2016
5fc49e3
Merge branch 'master' into db-init-fix
temochka Sep 10, 2016
b6c21d9
Update changelog. [skip ci]
temochka Sep 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ All notable changes to this project are documented in this file. This change log
## [Unreleased]

### Fixed
- Internal: Fixed possible test failures in non-UTC timezones.
- Internal: Fixed graceful shutdown test.
- Fix `queue/initialize!` that fails to create MySQL tables due to index conflict.
- Internal: Fix possible test failures in non-UTC timezones.
- Internal: Fix graceful shutdown test.

### Changed
- Use JVM time when querying for pending jobs instead of relying on UTC.
Expand Down
2 changes: 1 addition & 1 deletion src/mysql_queue/core.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,8 @@
(defn initialize!
"Create required MySQL tables if they don't exist. Returns true."
[db-conn]
(queries/create-jobs! db-conn)
(queries/create-scheduled-jobs! db-conn)
(queries/create-jobs! db-conn)
true)

(defn schedule-job
Expand Down
3 changes: 1 addition & 2 deletions test/mysql_queue/core_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@

(defn setup-db
[f]
(queries/create-scheduled-jobs! db-conn)
(queries/create-jobs! db-conn)
(initialize! db-conn)
(f))

(defn clean-up
Expand Down