feat: add Regulation Mode text sensor (CV/CC)#16
Open
malaiwah wants to merge 1 commit into
Open
Conversation
The "Constant Voltage" and "Constant Current" binary sensors both derive from bit 0 of holding register 17 — they are tautologically opposite. Two entities for one bit is redundant. Adds a new "Regulation Mode" text_sensor that exposes "CV" / "CC" directly. The legacy binary sensors are kept for backward compatibility with existing dashboards and automations; a comment marks them as preferred-deprecated. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
Adds a single
Regulation Modetext_sensor populated from the existing CV binary_sensor'son_state. Reports"CV"or"CC"directly.Both legacy binary_sensors are preserved with a deprecation comment so existing dashboards / automations keep working.
Verification
esphome configpasses for bothrdtech-controller.yamlandrdtech-controller-c3.yamlesphome compileagainst ESPHome 2025.x with esp01_1m board: clean (no lambda errors, RAM 46.3% / Flash 49.4%)Disclosure
This change was drafted with assistance from Claude (Anthropic). The author reviewed every line, validated upstream against the codebase, and signed off. The commit carries a
Co-Authored-By: Claudetrailer per common convention.