feat: substitution for Modbus slave address#28
Open
malaiwah wants to merge 1 commit into
Open
Conversation
Replaces the hardcoded 0x01 in the modbus_controller section with a
${slave_address} substitution, defined alongside the other
device-level substitutions at the top of the YAML.
Default is unchanged (0x01) so existing flashes keep working as-is.
The PSU exposes a Modbus address knob (1-247 per spec); the stock
dongle is a one-PSU device, so most users never touch it. The
substitution makes the rare multi-drop case (one ESP + external
TTL/RS-485 transceiver driving several PSUs, each on its own
binary) editable without forking the file.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27
Replaces the hardcoded
address: 0x01withaddress: ${slave_address}. Default value unchanged so existing flashes keep working.The substitution comment notes that the stock dongle is a one-PSU device; the rare multi-drop scenario needs a separate firmware build per PSU with the matching slave_address (since each ESP only addresses one slave).
Verification
esphome configpasses both YAMLsDisclosure
Drafted with Claude (Anthropic). Author-reviewed.