Repository navigation
Switch helloworld client to fat JAR with --ssl option - #513
Merged
Merged
Conversation
Replace exec-maven-plugin with maven-shade-plugin to produce a self-contained helloworld-client.jar. Refactor argument parsing to use --ssl=<mode> option with name as positional arg, matching the chat client pattern. Extract SSL channel logic into SslMode enum.
7 tasks
jmesnil
requested changes
Oct 8, 2026
| This produces a fat JAR that can be launched directly: | ||
|
|
||
| ```shell | ||
| # clear text connection |
Member
There was a problem hiding this comment.
I think we should still keep the grpcurl commands as an alternative to the client
Collaborator
Author
There was a problem hiding this comment.
grpcurl commands are back in the REAMDE.md
jmesnil
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec-maven-pluginwithmaven-shade-pluginto produce a self-containedhelloworld-client.jar--ssl=<mode>option with name as positional arg, matching the chat client pattern from [#490] Replace JavaFX chat client with TamboUI terminal UI #511SslModeenumTest plan
mvn package -pl examples/helloworld/client -amjava -jar target/helloworld-client.jar Bobagainst a running server--ssl=onewayand--ssl=twowaymodes work--helpprints usage