Repository navigation
Conversation
hpehl
reviewed
Oct 8, 2026
| @RunAsClient | ||
| public class JsonSerializationTest { | ||
|
|
||
| private static final String TARGET = "localhost:9555"; |
Collaborator
There was a problem hiding this comment.
We have a repeating pattern in the tests to define the target host and port and to create channels:
Package org.wildfly.feature.pack.grpc.test.helloworld
HelloWorldParent defines
protected static final String TARGET = "localhost:9555";
protected static final String TARGET_HOST = "localhost";
protected static final int TARGET_PORT = 9555;which is used in
-
PlaintextHelloWorldTestchannel = ManagedChannelBuilder.forTarget(TARGET).usePlaintext().build();
-
OnewaySecureHelloWorldTestchannel = Grpc.newChannelBuilderForAddress(TARGET_HOST, TARGET_PORT, creds).build();
-
TwowaySecureHelloWorldTestchannel = Grpc.newChannelBuilderForAddress(TARGET_HOST, TARGET_PORT, creds).build();
Package org.wildfly.feature.pack.grpc.test.stream
StreamingTestParent defines
protected static final String TARGET = "localhost:9555";
protected static final String TARGET_HOST = "localhost";
protected static final int TARGET_PORT = 9555;which is used in
-
PlaintextStreamingTestchannel = ManagedChannelBuilder.forTarget(TARGET).usePlaintext().build();
-
OnewaySecureStreamingTestchannel = Grpc.newChannelBuilderForAddress(TARGET_HOST, TARGET_PORT, creds).build();
-
TwowaySecureStreamingTest -
channel = Grpc.newChannelBuilderForAddress(TARGET_HOST, TARGET_PORT, creds).build();
This is not much repeating code atm, but it might make sense to have at least the constants for the target host and port in one place.
jmesnil
force-pushed
the
json-serialization-tests
branch
from
October 13, 2026 08:47
e1808f8 to
1195c67
Compare
Verify that JsonFormat (from protobuf-java-util, backed by Gson) is accessible from a WildFly deployment, as enabled by the optional com.google.code.gson dependency added to the com.google.protobuf module. - JsonGreeterServiceImpl: service impl that uses JsonFormat to round-trip the request through JSON serialization before building the response - JsonSerializationTest: Arquillian integration test that deploys the service and verifies the call succeeds over a plaintext connection - Add protobuf-java-util as provided dependency to the testsuite pom (it is available in WildFly at runtime; needed only for compilation) Closes wildfly-extras#510 Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
jmesnil
force-pushed
the
json-serialization-tests
branch
from
October 21, 2026 09:30
1195c67 to
a40aa72
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify that JsonFormat (from protobuf-java-util, backed by Gson) is accessible from a WildFly deployment, as enabled by the optional com.google.code.gson dependency added to the com.google.protobuf module.
Closes #510