Skip to content

Ely 2534 OIDC logout farah#2230

Closed
rsearls wants to merge 6 commits intowildfly-security:2.xfrom
rsearls:ELY-2534-OIDC-logout-Farah
Closed

Ely 2534 OIDC logout farah#2230
rsearls wants to merge 6 commits intowildfly-security:2.xfrom
rsearls:ELY-2534-OIDC-logout-Farah

Conversation

@rsearls
Copy link
Copy Markdown
Contributor

@rsearls rsearls commented Oct 7, 2024

https://issues.redhat.com/browse/ELY-2534 Logout support for OIDC

This PR supersedes #1882 which is a year old
and updated code in https://github.com/fjuma/wildfly-elytron/commits/ELY-2534/ that is several months old.

@rsearls rsearls requested review from fjuma and skyllarr as code owners October 7, 2024 22:14
@fjuma
Copy link
Copy Markdown
Contributor

fjuma commented Oct 10, 2024

@rsearls Thanks for this PR!

Was just about to re-trigger CI and noticed there's a compilation failure:

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0-jboss-1:testCompile (default-testCompile) on project wildfly-elytron-http-oidc: Compilation failure
Error:  /home/runner/work/wildfly-elytron/wildfly-elytron/http/oidc/src/test/java/org/wildfly/security/http/oidc/AbstractLogoutTest.java:[83,81] unreported exception java.lang.Exception; must be caught or declared to be thrown

@rsearls
Copy link
Copy Markdown
Contributor Author

rsearls commented Oct 10, 2024

Yes I'm working on it. There is also a test failure with BackChannelLogoutTest which I am working to resolve.

@fjuma fjuma mentioned this pull request Nov 19, 2024
3 tasks
@fjuma
Copy link
Copy Markdown
Contributor

fjuma commented Jan 3, 2025

Closing this one since it's been superseded by #2245

@fjuma fjuma closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants