[ELY-2915] Add a new org.wildfly.security:wildfly-elytron-all bom#2291
[ELY-2915] Add a new org.wildfly.security:wildfly-elytron-all bom#2291theashiot wants to merge 1 commit intowildfly-security:2.xfrom
Conversation
| </parent> | ||
|
|
||
| <packaging>pom</packaging> | ||
| <artifactId>wildfly-tools-builder</artifactId> |
There was a problem hiding this comment.
wildfly-elytron-bom-builder-all
|
|
||
| <packaging>pom</packaging> | ||
| <artifactId>wildfly-tools-builder</artifactId> | ||
| <name>WildFly BOM Builders: Tools Builder</name> |
There was a problem hiding this comment.
WildFly Elytron BOM Builder: All
| <packaging>pom</packaging> | ||
| <artifactId>wildfly-tools-builder</artifactId> | ||
| <name>WildFly BOM Builders: Tools Builder</name> | ||
| <description>This artifact builds a bill of materials (BOM), providing Dependency Management with Tools useful for WildFly</description> |
There was a problem hiding this comment.
This artifact builds a bill of materials (BOM), providing Dependency Management with all Elytron artifacts
| <relativePath/> | ||
| </parent> | ||
| <bomGroupId>org.wildfly.security</bomGroupId> | ||
| <bomArtifactId>wildfly-elytron-all</bomArtifactId> |
| <bomGroupId>org.wildfly.security</bomGroupId> | ||
| <bomArtifactId>wildfly-elytron-all</bomArtifactId> | ||
| <bomVersion>${project.version}</bomVersion> | ||
| <bomName>WildFly Elytron BOM</bomName> |
There was a problem hiding this comment.
WildFly Elytron BOM: All
| <groupId>org.wildfly.security</groupId> | ||
| <artifactId>wildfly-elytron-x500-principal</artifactId> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Remove this one, we only need to include the top level artifacts, any transitive will be added by the bom builder plugin. There could be an exception tho, in the case it's a runtime only dependency that is not declared anywhere as transitive.
| <bomDescription>Dependency Management with all Elytron modules</bomDescription> | ||
| <inheritExclusions>ALL</inheritExclusions> | ||
| <includeTransitives>true</includeTransitives> | ||
| <includeDependencies> |
There was a problem hiding this comment.
add also <bomWithDependencies>true</bomWithDependencies>, otherwise you only build a BOM with dependencyManagement, i.e. you can't use it as a dependency.
|
Thanks, @emmartins for the review! I've made all the changes. Can you please have a look? |
|
Closing this as the changes should be made to 2.6.x. Here's the new PR: #2292 |
2 participants
https://issues.redhat.com/browse/ELY-2915