[WFDESC-37] Adjust takeService() method to use (default) timeout value specified in constructor - #31
Open
rachmatowicz wants to merge 1 commit into
Open
[WFDESC-37] Adjust takeService() method to use (default) timeout value specified in constructor#31rachmatowicz wants to merge 1 commit into
rachmatowicz wants to merge 1 commit into
Conversation
Contributor
Author
|
NOTE: don't merge this just yet, I should write a test case to test this! |
…e specified in constructor.
rachmatowicz
force-pushed
the
WFDISC-37
branch
from
January 5, 2021 01:43
a089969 to
c17caa1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
-- calls to takeService() use the default timeout specified by the constructor
-- calls to takeService(timeout, timeunit) use the timeout specified in the method call instance
The "fully blocking" style is arranged either by creating the queue using the no parameter constructor and calling takeService() or passing a Long.MAX_VALUE timeout parameter to the method call takeService(timeout, timeunit) to override any constructor timeout value.