Skip to content

Conversation

@rachmatowicz
Copy link
Collaborator

@rachmatowicz rachmatowicz commented Oct 11, 2024

Draft version of the wire-spec-v2.
A wire spec does not get into implementation details, so I have tried to give an overall descrption of what the protocol is trying to do and any additional request response data required.

@ropalka
Copy link
Collaborator

ropalka commented Oct 17, 2024

I just managed to review the diff between v1 & v2 documents. All looks good to me @rachmatowicz .

@rachmatowicz
Copy link
Collaborator Author

rachmatowicz commented Oct 21, 2024

I need to add the discovery operation wire spec. This was also omitted from v1.
Added sections for discovery. Fixed a few typos which were causing formatting to be misaligned.

@ropalka
Copy link
Collaborator

ropalka commented Oct 22, 2024

Reviewed also Discovery request / response amendment. Still LGTM.

@rachmatowicz rachmatowicz marked this pull request as ready for review November 6, 2024 19:17
@rachmatowicz rachmatowicz requested a review from fl4via as a code owner November 6, 2024 19:17
@rachmatowicz
Copy link
Collaborator Author

rachmatowicz commented Nov 6, 2024

I've made the final updates to this document. I tried to harmonize the content of the sections (using the same section headers in each section, like Message Type, Additional Required Headers, Additional Optional Headers, etc), and added the interoperability headers into the protocol descriptions.

@ropalka
Copy link
Collaborator

ropalka commented Nov 8, 2024

Reviewed also after the final update of the document - LGTM.

@rachmatowicz
Copy link
Collaborator Author

Just realigned a few fields with no changes to content.

@rachmatowicz
Copy link
Collaborator Author

rachmatowicz commented Dec 4, 2024

I have updated the document to remove references to the x-wf-version header which is only used in v1 messages and and added an explanatory note in the changes since v1 section. This can be merged as I won't be making any further changes.

@@ -0,0 +1,522 @@
= Wildfly Service Invocation over HTTP Specification (v2)
:Author: Stuart Douglas
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rachmatowicz you are the author, and please also update the date and revision

@ropalka ropalka merged commit cb8d26a into wildfly:main Dec 13, 2024
12 checks passed
@ropalka
Copy link
Collaborator

ropalka commented Dec 13, 2024

Thanks @rachmatowicz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants