Skip to content

Disable ant download from the old authentication, security and faces tcks - #250

Open
TomasHofman wants to merge 1 commit into
wildfly:jakarta-ee-10from
TomasHofman:disable-ant-download
Open

Disable ant download from the old authentication, security and faces tcks#250
TomasHofman wants to merge 1 commit into
wildfly:jakarta-ee-10from
TomasHofman:disable-ant-download

Conversation

@TomasHofman

Copy link
Copy Markdown

This is the second attempt.

Setting -Ddownload.plugin.skip=true didn't help, because the plugin is reconfigured to use the skipITs property to control its skipping, instead of the default download.plugin.skip:

                    <execution>
                        <id>download-ant</id>
                        <phase>generate-sources</phase>
                        <goals>
                            <goal>wget</goal>
                        </goals>
                        <configuration>
                            <skip>${skipITs}</skip>
                            <url>${ant.zip.url}</url>
                            <unpack>true</unpack>
                            <outputDirectory>${project.build.directory}</outputDirectory>
                        </configuration>
                    </execution>

But setting skipITs=true would also have other effects, so I'm looking at another way to avoid download from the apache archive.

This however relies on the apacheant caching job archived artifacts to remain available, and requires to job to always archive the hardcoded 1.9.16 version. (It doesn't need to be this specific version, we just need to keep it in synch with what is hardcoded in the run-tck.sh scripts.)

WDYT @scottmarlow @jamezp ?

jamezp
jamezp previously approved these changes Aug 1, 2025

@jamezp jamezp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. We can always change the property to not use skipITs or default the property value to skipITs.

@TomasHofman

Copy link
Copy Markdown
Author

This seems fine. We can always change the property to not use skipITs or default the property value to skipITs.

For that you would have to change the TCK pom.xml (third party code)... So in this PR I don't try to configure the download module to skip operation, but instead change the download URL to internal cached URL, which can still be done just by setting system props.

(Just making sure we are at the same page.)

@jamezp
jamezp dismissed their stale review August 1, 2025 15:12

This won't work as it uses internal URL's

@jamezp

jamezp commented Aug 1, 2025

Copy link
Copy Markdown
Member

We probably shouldn't be using an internal URL in a public repository. It would break for anyone using it externally.

@TomasHofman
TomasHofman force-pushed the disable-ant-download branch from 371c5cb to aacdf05 Compare August 1, 2025 17:51
@TomasHofman

Copy link
Copy Markdown
Author

So I changed the URL to "https://dlcdn.apache.org/ant/binaries/apache-ant-${ANT_VERSION}-bin.zip". Did you notice denied access from that URL too? I think I did not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants