Disable ant download from the old authentication, security and faces tcks - #250
Disable ant download from the old authentication, security and faces tcks#250TomasHofman wants to merge 1 commit into
Conversation
jamezp
left a comment
There was a problem hiding this comment.
This seems fine. We can always change the property to not use skipITs or default the property value to skipITs.
For that you would have to change the TCK pom.xml (third party code)... So in this PR I don't try to configure the download module to skip operation, but instead change the download URL to internal cached URL, which can still be done just by setting system props. (Just making sure we are at the same page.) |
|
We probably shouldn't be using an internal URL in a public repository. It would break for anyone using it externally. |
371c5cb to
aacdf05
Compare
|
So I changed the URL to "https://dlcdn.apache.org/ant/binaries/apache-ant-${ANT_VERSION}-bin.zip". Did you notice denied access from that URL too? I think I did not. |
This is the second attempt.
Setting
-Ddownload.plugin.skip=truedidn't help, because the plugin is reconfigured to use theskipITsproperty to control its skipping, instead of the defaultdownload.plugin.skip:But setting
skipITs=truewould also have other effects, so I'm looking at another way to avoid download from the apache archive.This however relies on the apacheant caching job archived artifacts to remain available, and requires to job to always archive the hardcoded 1.9.16 version. (It doesn't need to be this specific version, we just need to keep it in synch with what is hardcoded in the run-tck.sh scripts.)
WDYT @scottmarlow @jamezp ?