Spenbert/manifold extraction#876
Merged
Merged
Conversation
…cal_offset * commit '6f8ed04f6c766806f659b6336f21210a2d80d35a': Basic code for surface smoothing in tet_remeshing. Basic code for mesh annotations. Clear splitting caches. fix assert Compute winding number per input mesh. Set edge length convergence parameter from JSON. Add missing tetgen option. # Conflicts: # components/CMakeLists.txt
…lkit into spenbert/manifold_extraction * 'main' of https://github.com/wildmeshing/wildmeshing-toolkit: Fix TriMesh split rollback issue.
daniel-zint
reviewed
Feb 4, 2026
daniel-zint
left a comment
daniel-zint
left a comment
Contributor
There was a problem hiding this comment.
Not fully done, but I have to board my flight now. This should be plenty already, though.
daniel-zint
reviewed
Feb 16, 2026
daniel-zint
left a comment
daniel-zint
left a comment
Contributor
There was a problem hiding this comment.
A few more comments. Please respond to the comments or mark them as resolved if you did actually resolve them. That makes my review process much easier.
I think if you go through my comments again, the PR will be ready for merging.
But also make sure that the CI passes on every machine. Currently, it only passes on Mac.
daniel-zint
approved these changes
Feb 18, 2026
daniel-zint
left a comment
daniel-zint
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I'll merge as soon as the tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.