fix: permission-aware mutation UX — hide/disable controls in read-only simulations (#127, #128)#136
Closed
wilhel1812 wants to merge 20 commits intomainfrom
Closed
fix: permission-aware mutation UX — hide/disable controls in read-only simulations (#127, #128)#136wilhel1812 wants to merge 20 commits intomainfrom
wilhel1812 wants to merge 20 commits intomainfrom
Conversation
- Replace branchy cartoThemedTint with typed Record<UiColorTheme> map - Add satisfies guard so missing themes fail at compile time - Add yellow tint values (yolk orange shift) - Add basemap.test.ts covering all themes light/dark - Add Theme + Basemap Integration Checklist to AGENTS.md
Keep the unread badge visible on the user chip for all users while consolidating full notification content in User Settings. Add credentials-included notifications fetch and coverage tests for client request/options normalization.
Owner
Author
|
Closing this historical stacked PR to reduce branch debt. The 0.10.0 release is out, and this scope should be re-planned as a fresh, focused PR when resumed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
canMutateActiveSimulation(),countNonEditableResourceIds(), andgetMutationPermissionMessage()shared helpers insrc/lib/editAccess.tsdisabled={!canMutateSimulation}+ permission-aware error messagesSave a Copy,New Simulation,Add Site to Library) gated oncanCreateOwnedResources— allowed even in read-only simulationscanPersistnpm test(126 tests ✓) andnpm run build(✓)Closes #127. Closes #128.