Skip to content

feat: per-row icon actions for sites and links sidebar (#803)#805

Merged
wilhel1812 merged 1 commit intostagingfrom
issue/803-sidebar-site-link-icon-actions
Apr 28, 2026
Merged

feat: per-row icon actions for sites and links sidebar (#803)#805
wilhel1812 merged 1 commit intostagingfrom
issue/803-sidebar-site-link-icon-actions

Conversation

@wilhel1812
Copy link
Copy Markdown
Owner

Summary

  • Sites list rows: removed ASL elevation display; added pencil (edit) and circle-minus (remove) icon buttons aligned to the right of each row
  • Links list rows: added matching pencil and circle-minus icon buttons per row
  • Sites panel chip-group: added "New" button (opens library add-form); removed bottom Edit and Remove buttons
  • Links panel chip-group: removed bottom Edit and Remove buttons; "New" button remains
  • In read-only mode: icon buttons are hidden; no chip changes needed

Refactors

  • openLibraryForSelectedSiteopenLibraryForSite(site: Site) — now takes a site directly so it can be called from any row
  • openEditLinkModal()openEditLinkModal(linkId?: string) — resolves link internally to avoid React state timing issues when called per-row

Test plan

  • Site rows show name only (no ASL), pencil + circle-minus icon buttons visible
  • Pencil on site opens library/edit form scoped to that site
  • Circle-minus on site triggers remove confirmation; disabled when only 1 site remains
  • Link rows show title, pencil + circle-minus icon buttons visible
  • Pencil on link opens edit modal pre-filled for that link
  • Circle-minus on link triggers delete confirmation
  • Sites chip-group: New, Library, Insert newest — no Edit/Remove
  • Links chip-group: New only — no Edit/Remove
  • All read-only: no icon buttons on rows, no New chip
  • npm test passes (454 tests)
  • npm run build passes

Closes #803

🤖 Generated with Claude Code

…803)

- Sites list: remove ASL meta, add pencil (edit) and circle-minus (remove) icon buttons per row
- Links list: add matching pencil and circle-minus icon buttons per row
- Sites panel: add "New" button opening library add-form; remove bottom Edit/Remove chips
- Links panel: remove bottom Edit/Remove chips, keep "New" button
- Refactor openLibraryForSelectedSite → openLibraryForSite(site) for per-row use
- Refactor openEditLinkModal to accept optional linkId for per-row use

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@wilhel1812 wilhel1812 merged commit 1f9f471 into staging Apr 28, 2026
5 checks passed
@wilhel1812 wilhel1812 deleted the issue/803-sidebar-site-link-icon-actions branch April 28, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant