feat: floating popover editor for sites, links, and simulations (#804)#806
Merged
wilhel1812 merged 1 commit intostagingfrom Apr 28, 2026
Merged
feat: floating popover editor for sites, links, and simulations (#804)#806wilhel1812 merged 1 commit intostagingfrom
wilhel1812 merged 1 commit intostagingfrom
Conversation
…nks, and simulations (#804) Introduces MapEditorPanel — a floating popover anchored to its trigger button — that unifies edit and create flows for site library entries, links, and simulation presets. Dismissed by ESC, outside-click, or ×; renders as a bottom sheet on mobile. Old ModalOverlay blocks for resourceDetailsPopup and linkModal are now dead code. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resourceDetailsPopupandlinkModalModalOverlay editors withMapEditorPanel— a floating popover anchored to the invoking sidebar buttonAccessSettingsEditorand all existing fields)mapEditorslice added to appStore (openMapEditor/closeMapEditor); trigger buttons passgetBoundingClientRect()at click time — no ref threading requireduseMapEditorFormStatehook owns all draft state previously spread across Sidebar.tsxTest plan
npm test— 461 tests pass;npm run build— clean🤖 Generated with Claude Code