Update categorize.R #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decisionList$test.sm_tmax_IntensityRatio <- decisionList$sm_tmax_IntensityRatio > threshold_sm_tmax_IntensityRatio Incorrectly compares decisionList$sm_tmax_IntensityRatio to threshold_dsm_tmax_IntensityRatio Amended to decisionList$test.sm_tmax_IntensityRatio <- decisionList$sm_tmax_IntensityRatio > threshold_sm_tmax_IntensityRatio Default value for threshold_sm_tmax_IntensityRatio changed to 0.75 to avoid any change to the behaviour of the package
|
We have moved sicegar to https://github.com/hardin47/sicegar and will update to CRAN soon. We have edited your first suggestion, and it will soon be available in the newest version of sicegar, 0.3.0. We are not sure about the intent of the second suggestion as the parameter estimation for double sigmoidal fit requires estimating many more parameters. We have not seen simulations or evidence that 0.75 is necessarily better than 0.85, so we have left the default values as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decisionList$test.sm_tmax_IntensityRatio <- decisionList$sm_tmax_IntensityRatio > threshold_sm_tmax_IntensityRatio Incorrectly compares decisionList$sm_tmax_IntensityRatio to threshold_dsm_tmax_IntensityRatio Amended to decisionList$test.sm_tmax_IntensityRatio <- decisionList$sm_tmax_IntensityRatio > threshold_sm_tmax_IntensityRatio
Default value for threshold_sm_tmax_IntensityRatio changed to 0.75 to avoid any change to the behaviour of the package