build: decouple secp256 tests from BUILD_TESTS #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests add a minimum of a few minutes to the unit test runtime, and
at worst see runtime double.
Decouple them from ${BUILD_TESTS} so that they can be more selectively
enabled/disabled.
willcl-ark
force-pushed
the
disable-secp-tests
branch
from
7fe68fe to
5fa53f0
Compare
This workflow job detects whether the secp256k1 subtree was updated, and, if it was, will build and run the secp256k1 unit tests. These are disable by default (in other CI jobs), as they doubel the runtime needed, and rarely change.
We could choose to enable the secp256 tests in dev mode, but I'm not convinced that it's even necessary here, unless the subtree changes.
Dummy commit to show the new CI job running.
willcl-ark
force-pushed
the
disable-secp-tests
branch
from
5fa53f0 to
267ba87
Compare
willcl-ark
force-pushed
the
master
branch
24 times, most recently
from
2fcab0a to
b78454f
Compare
github-actions
bot
force-pushed
the
master
branch
3 times, most recently
from
97ed557 to
e472e80
Compare
willcl-ark
force-pushed
the
master
branch
2 times, most recently
from
3108440 to
2370337
Compare
github-actions
bot
force-pushed
the
master
branch
2 times, most recently
from
a5d742e to
acc041c
Compare
willcl-ark
force-pushed
the
master
branch
2 times, most recently
from
37a6a6d to
4cdce02
Compare
github-actions
bot
force-pushed
the
master
branch
4 times, most recently
from
6a31544 to
acff675
Compare
willcl-ark
force-pushed
the
master
branch
9 times, most recently
from
ed138e2 to
2ccfcf2
Compare
willcl-ark
force-pushed
the
master
branch
3 times, most recently
from
425aeb2 to
9827b14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.These tests add a minimum of a few minutes to the unit test runtime, and
at worst see runtime double.
Decouple them from ${BUILD_TESTS} so that they can be more selectively
enabled/disabled.