Skip to content

Commit 9786c60

Browse files
Remove removeBuilds.php page (Kitware#3630)
This functionality is provided by the `php artisan build:remove` Artisan command.
1 parent c5ed6df commit 9786c60

7 files changed

Lines changed: 0 additions & 227 deletions

File tree

app/Http/Controllers/AdminController.php

Lines changed: 0 additions & 107 deletions
This file was deleted.

app/cdash/tests/test_removebuilds.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,6 @@ public function __construct()
3737
parent::__construct();
3838
}
3939

40-
public function testRemoveBuilds(): void
41-
{
42-
$this->login();
43-
$this->get($this->url . '/removeBuilds.php?projectid=5');
44-
$this->clickSubmitByName('Submit');
45-
if (!str_contains($this->getBrowser()->getContentAsText(), 'Removed')) {
46-
$this->fail("'Removed' not found when expected");
47-
}
48-
}
49-
5040
public function testBuildRemovalWorksAsExpected(): void
5141
{
5242
$time = gmdate(FMT_DATETIME);

phpstan-baseline.neon

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -504,30 +504,6 @@ parameters:
504504
count: 1
505505
path: app/Http/Controllers/AbstractProjectController.php
506506

507-
-
508-
rawMessage: Cannot cast mixed to int.
509-
identifier: cast.int
510-
count: 8
511-
path: app/Http/Controllers/AdminController.php
512-
513-
-
514-
rawMessage: 'Construct empty() is not allowed. Use more strict comparison.'
515-
identifier: empty.notAllowed
516-
count: 1
517-
path: app/Http/Controllers/AdminController.php
518-
519-
-
520-
rawMessage: 'Method App\Http\Controllers\AdminController::removeBuilds() never returns Illuminate\Http\RedirectResponse so it can be removed from the return type.'
521-
identifier: return.unusedType
522-
count: 1
523-
path: app/Http/Controllers/AdminController.php
524-
525-
-
526-
rawMessage: 'Parameter #2 $timestamp of function date expects int|null, (int|false) given.'
527-
identifier: argument.type
528-
count: 3
529-
path: app/Http/Controllers/AdminController.php
530-
531507
-
532508
rawMessage: Access to an undefined property App\Http\Controllers\Auth\LoginController::$decayMinutes.
533509
identifier: property.notFound

resources/js/vue/components/AdministrationPage.vue

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@
1616
title="Manage Authentication Tokens"
1717
:icon="FA.faKey"
1818
/>
19-
<administration-page-card
20-
href="/removeBuilds.php"
21-
title="Remove Builds"
22-
:icon="FA.faTrashCan"
23-
/>
2419
<administration-page-card
2520
href="/monitor"
2621
title="Submission Status"

resources/views/admin/remove-builds.blade.php

Lines changed: 0 additions & 77 deletions
This file was deleted.

routes/web.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -317,9 +317,6 @@
317317

318318
Route::get('/authtokens/manage', 'AuthTokenController@manage');
319319

320-
Route::get('/removeBuilds.php', 'AdminController@removeBuilds');
321-
Route::post('/removeBuilds.php', 'AdminController@removeBuilds');
322-
323320
Route::get('/monitor', 'MonitorController@monitor');
324321
Route::get('/monitor.php', fn () => redirect('/monitor', 301));
325322
});

tests/Feature/RouteAccessTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ public static function protectedRoutes(): array
6464
public static function adminRoutes(): array
6565
{
6666
return [
67-
['/removeBuilds.php'],
6867
['/monitor'],
6968
];
7069
}

0 commit comments

Comments
 (0)