fix(XYChart, Network): Preserve passed onMouseLeave and onMouseMove #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Currently if a user of
XYChart
orNetwork
passes their ownonMouseLeave
oronMouseMove
props in addition to arenderTooltip
prop, the mouse handlers are overwritten by theWithTooltip
provided mouse handlers and never invoked.This PR fixes this by
@data-ui/shared
sWithTooltip
to acceptonMouseLeave
andonMouseMove
functions, which are invoked when the provided equivalents are called.XYChart
andNetwork
to pass along the user-providedonMouseLeave
andonMouseMove
toWithTooltip
Test plan
WithTooltip