fixed to work with ida 7.0 #4
Open
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williballenthin
requested changes
Nov 30, 2019
Owner
williballenthin
left a comment
williballenthin
left a comment
There was a problem hiding this comment.
thanks for the contribution!
| md5 = idautils.GetInputFileMD5().decode("utf-8", errors="ignore").rstrip('\x00') | ||
| ret = [] | ||
| ret.append(f'rule a_{md5}_{safe_name}') | ||
| ret.append('rule a_{}_{}'.format(md5, safe_name)) |
| else: | ||
| bytes.append(byte) | ||
| masked_bytes.append('%02X' % (byte)) | ||
| masked_bytes.append('%02x' % int(byte.encode('hex'), 16)) |
Owner
There was a problem hiding this comment.
this looks a bit roundabout. could the same be accomplished like: (ord(byte)) ?
i'm also hesitant about py2/py3 here. the proposed solution looks like its a py2 construct. would you add a version switch here to handle both py2 and py3?
Author
|
This also seems to cause IDA Pro to become unresponsive when trying to close it. I wonder if IDA Python is holding a handle or the script isn't being exited properly? Ill see if I can fix up those 2 lines |
williballenthin
force-pushed
the
master
branch
20 times, most recently
from
fe7896a to
3c9f7e2
Compare
williballenthin
force-pushed
the
master
branch
7 times, most recently
from
43c6eef to
3a80405
Compare
williballenthin
force-pushed
the
master
branch
14 times, most recently
from
5d8e88a to
f6e7d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't working in 7.0 so added some changes to how the bytes are printed