Handle in-flight Modbus reads during Home Assistant shutdown - #2096
Merged
Conversation
Owner
|
Are you planning to include this in 2026.05.5? Or leave it for a future release? |
Contributor
Author
|
You can add this one to 2026.05.05 as well. Not a dramatic one but currently we cause errors when HA restarts. |
wills106
marked this pull request as ready for review
May 30, 2026 11:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopping SolaX Modbus hubs on the Home Assistant stop event and collect expected pymodbus cancellation results from in-flight read tasks during shutdown. This prevents "Request cancelled outside pymodbus" from leaking as an unhandled shutdown exception while preserving normal Modbus error handling during runtime.