feat: add Fourier and vectorized Polynomial basis functions with accompanying tests. #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! This PR adds the include_bias option to Polynomial and Fourier basis functions.
Right now, some basis functions like Legendre and Hermite already let you control whether to include a bias term, but Polynomial and Fourier didn't have that option. This was limiting for certain modeling scenarios where you might not want the bias term.
What changed:
Trueto match what Legendre, Hermite, etc. are doinginclude_bias=Trueandinclude_bias=Falsework correctlyTesting:
Tested manually and everything works as expected:
include_bias=True, you get a column of ones prepended to the outputinclude_bias=False, no bias column is addedLet me know if you'd like me to change anything!
Fixes #193