Skip to content

Conversation

@xhaggi
Copy link
Collaborator

@xhaggi xhaggi commented Nov 24, 2024

Fixes gh-147 gh-148

@wimdeblauwe
Copy link
Owner

Thank you for your work @xhaggi. I find a bit a pity we closed @odrotbohm 's PR just like that. I think we could have merged it to honor his effort and then went from there. This PR is quite big, combining several things. I like to have smaller PR's. But it is ok for me now. Just 2 things:

  1. I want to hold off this until we release 3.6.2 with the fix the exception handler methods
  2. We should also update the README with the changes.

@odrotbohm
Copy link
Contributor

Don't worry too much about my PR. All I wanted to convey was the extent of code we can get rid of by moving to the FragementRendering API, and it's that single class primarily. It's been the result of an early prototype I built to verify the APIs in Framework for suitability. Please feel completely free to move forward as you see fit.

@xhaggi
Copy link
Collaborator Author

xhaggi commented Nov 25, 2024

Rebased. The last commit now contains an update to the README to point out the HTML fragment support.

@wimdeblauwe
Copy link
Owner

Looks good 👍

@xhaggi xhaggi merged commit 2e08a6c into wimdeblauwe:main Nov 25, 2024
2 checks passed
@xhaggi xhaggi deleted the feature/gh-147 branch November 25, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Spring Boot 3.4.x

3 participants