[fix] broken HtmxResponse handling since 9cc73313 #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checketts
approved these changes
Dec 5, 2024
Owner
|
Thanks. Is there no way to write a test that will avoid we will have this bug again in the future? |
xhaggi
force-pushed
the
fix/gh-155
branch
2 times, most recently
from
b7254b1 to
d50d8cf
Compare
wimdeblauwe
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current versions 3.6.2 and 4.0.0, the handling of
HtmxResponseis broken, which means that no request headers are set, although the tests do not fail.Fixes #155